[v18.x backport] stream: streams and webstreams interop related changes by debadree25 · Pull Request #46314 · nodejs/node

debadree25 · 2023-01-23T11:43:11Z

Backports the following PRs:
#46190
#46273
#46307
#46312
#46315
#46403
#46600
#46675

nodejs-github-bot · 2023-01-23T11:43:16Z

Review requested:

@nodejs/streams

debadree25 · 2023-01-23T11:43:51Z

aduh95 · 2023-01-23T13:29:19Z

We need to wait on #46312 to land first, and backport the three PRs in one backport PR (i.e. you need to cherry-pick the two other commits onto this branch). I'm going to convert this to draft if that's OK as this can't happen until #46312 lands.

debadree25 · 2023-01-23T13:31:09Z

Sure no issue!

debadree25 · 2023-01-23T13:38:23Z

So overall would need to cherry-pick #46205, #46190, #46315 and #46312 into this single PR

debadree25 · 2023-02-27T09:10:36Z

Hi @aduh95 all the streams related changes have landed, should i open a fresh backport PR including all the changes?

aduh95 · 2023-02-27T09:40:27Z

You can keep this PR, you just need to push the other commits to your backport-46205-to-v18.x branch.

debadree25 · 2023-02-27T10:18:49Z

doc/api/stream.md

 <!-- YAML
 added: v10.0.0
 changes:
+  - version: v18.14.0


This was release in #46396 hence added the version here

debadree25 · 2023-02-27T10:28:30Z

Does this look ok @aduh95 ?

nodejs-github-bot · 2023-04-02T21:18:58Z

CI: https://ci.nodejs.org/job/node-test-pull-request/50833/

danielleadams · 2023-05-17T01:38:09Z

@debadree25 are you able to rebase this?

debadree25 · 2023-05-17T16:52:50Z

Sure will rebase this!

Refs: nodejs#39519 PR-URL: nodejs#46190 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>

PR-URL: nodejs#46312 Refs: nodejs#46190 Refs: nodejs#46205 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Refs: nodejs#46190 Refs: nodejs#46205 (comment) PR-URL: nodejs#46315 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

debadree25 · 2023-05-23T19:42:07Z

Hey @danielleadams rebased this, is it ok?
So sorry for the delay 😅😅😅

nodejs-github-bot · 2023-05-23T20:35:41Z

CI: https://ci.nodejs.org/job/node-test-pull-request/51943/

nodejs-github-bot · 2023-05-28T19:42:48Z

CI: https://ci.nodejs.org/job/node-test-pull-request/51988/

Refs: #39519 PR-URL: #46190 Backport-PR-URL: #46314 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>

PR-URL: #46312 Backport-PR-URL: #46314 Refs: #46190 Refs: #46205 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Refs: #46190 Refs: #46205 (comment) PR-URL: #46315 Backport-PR-URL: #46314 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

danielleadams · 2023-05-29T01:29:14Z

Landed in 0b92035...e8b5a61

Refs: nodejs#39519 PR-URL: nodejs#46190 Backport-PR-URL: nodejs#46314 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>

PR-URL: nodejs#46312 Backport-PR-URL: nodejs#46314 Refs: nodejs#46190 Refs: nodejs#46205 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Refs: nodejs#46190 Refs: nodejs#46205 (comment) PR-URL: nodejs#46315 Backport-PR-URL: nodejs#46314 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

nodejs-github-bot added needs-ci PRs that need a full CI run. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. web streams labels Jan 23, 2023

aduh95 marked this pull request as draft January 23, 2023 13:29

juanarbol force-pushed the v18.x-staging branch from 7351221 to fcfde34 Compare January 31, 2023 13:17

debadree25 closed this Feb 27, 2023

debadree25 force-pushed the backport-46205-to-v18.x branch from 7902a99 to b266adb Compare February 27, 2023 09:48

debadree25 reopened this Feb 27, 2023

debadree25 changed the title ~~[v18.x backport] stream: implement finished() for ReadableStream and WritableStream~~ [v18.x backport] stream: streams and webstreams interop related changes Feb 27, 2023

debadree25 force-pushed the backport-46205-to-v18.x branch from 7204237 to f27c29c Compare February 27, 2023 10:17

debadree25 commented Feb 27, 2023

View reviewed changes

debadree25 force-pushed the backport-46205-to-v18.x branch from f27c29c to 8f10c66 Compare February 27, 2023 10:23

debadree25 marked this pull request as ready for review February 28, 2023 10:00

juanarbol force-pushed the v18.x-staging branch from e17d857 to de64315 Compare March 5, 2023 04:04

mshima mentioned this pull request Mar 11, 2023

Node v18.14.0 breaks jhipster jhipster/generator-jhipster#21380

Closed

1 task

debadree25 requested a review from aduh95 March 12, 2023 11:12

debadree25 added 3 commits May 24, 2023 01:10

lib: add webstreams to Duplex.from()

2c1a619

Refs: nodejs#39519 PR-URL: nodejs#46190 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>

doc: include webstreams in finished() and Duplex.from() parameters

631afeb

PR-URL: nodejs#46312 Refs: nodejs#46190 Refs: nodejs#46205 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

debadree25 force-pushed the backport-46205-to-v18.x branch from 8f10c66 to 0291981 Compare May 23, 2023 19:41

debadree25 requested a review from danielleadams May 23, 2023 19:42

panva added the request-ci Add this label to start a Jenkins CI on a PR. label May 23, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 23, 2023

github-actions bot mentioned this pull request May 29, 2023

CI Reliability 2023-05-29 nodejs/reliability#580

Open

22 tasks

danielleadams approved these changes May 29, 2023

View reviewed changes

danielleadams pushed a commit that referenced this pull request May 29, 2023

doc: include webstreams in finished() and Duplex.from() parameters

402c1a3

PR-URL: #46312 Backport-PR-URL: #46314 Refs: #46190 Refs: #46205 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

danielleadams closed this May 29, 2023

This was referenced May 30, 2023

CI Reliability 2023-05-30 nodejs/reliability#581

Open

CI Reliability 2023-05-31 nodejs/reliability#582

Open

mshima mentioned this pull request May 31, 2023

support any node 18 lts jhipster/generator-jhipster#22372

Merged

6 tasks

Uh oh!

Conversation

debadree25 commented Jan 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Jan 23, 2023

Uh oh!

debadree25 commented Jan 23, 2023

Uh oh!

aduh95 commented Jan 23, 2023

Uh oh!

debadree25 commented Jan 23, 2023

Uh oh!

debadree25 commented Jan 23, 2023

Uh oh!

debadree25 commented Feb 27, 2023

Uh oh!

aduh95 commented Feb 27, 2023

Uh oh!

debadree25 Feb 27, 2023

Choose a reason for hiding this comment

Uh oh!

debadree25 commented Feb 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Apr 2, 2023

Uh oh!

danielleadams commented May 17, 2023

Uh oh!

debadree25 commented May 17, 2023

Uh oh!

debadree25 commented May 23, 2023

Uh oh!

nodejs-github-bot commented May 23, 2023

Uh oh!

nodejs-github-bot commented May 28, 2023

Uh oh!

danielleadams commented May 29, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

debadree25 commented Jan 23, 2023 •

edited

Loading

debadree25 commented Feb 27, 2023 •

edited

Loading